Articles | Volume 17, issue 10
https://doi.org/10.5194/gmd-17-4467-2024
© Author(s) 2024. This work is distributed under the Creative Commons Attribution 4.0 License.
Implementation and evaluation of diabatic advection in the Lagrangian transport model MPTRAC 2.6
Download
- Final revised paper (published on 29 May 2024)
- Preprint (discussion started on 21 Nov 2023)
Interactive discussion
Status: closed
Comment types: AC – author | RC – referee | CC – community | EC – editor | CEC – chief editor
| : Report abuse
- RC1: 'Comment on gmd-2023-214', Anonymous Referee #1, 03 Jan 2024
- RC2: 'Comment on gmd-2023-214', Anonymous Referee #2, 10 Jan 2024
- AC1: 'Comment on gmd-2023-214', Jan Heinrich Clemens, 06 Mar 2024
Peer review completion
AR – Author's response | RR – Referee report | ED – Editor decision | EF – Editorial file upload
AR by Jan Heinrich Clemens on behalf of the Authors (06 Mar 2024)
Author's response
Author's tracked changes
Manuscript
ED: Referee Nomination & Report Request started (12 Mar 2024) by Volker Grewe
RR by Anonymous Referee #2 (26 Mar 2024)
ED: Publish as is (28 Mar 2024) by Volker Grewe
AR by Jan Heinrich Clemens on behalf of the Authors (05 Apr 2024)
Manuscript
This article describes the adaptation of a Lagrangian transport model, MPTRAC, to use diabatic velocity coordinates, the use of which are beneficial to Lagrangian transport calculations. The main component of this is an interpolation scheme to compute these diabatic velocities at particle locations, which requires a vertical search.
The adapted model is benchmarked against another model, CLaMS, using a sensible set of case studies, where the errors are compared to those within MPTRAC upon variation of parameters. This is a good practical approach.
My main point about the paper is that it is motivated by performance on next generation HPC, but nothing is said about performance in this paper. I appreciate that performance optimisation is a second step after checking that the numerical approach is sufficient (that's the main content of this paper). However the general reader would appreciate a bit more discussion. So,
1. What is it about MPTRAC that makes it expected to perform better than CLaMS on GPUs etc? Are these properties preserved by the new adaptation? Can this be argued from a performance model?
2. Can you provide a performance profile of the new adaptation versus the standard MPTRAC to see where potential bottlenecks have arisen, and discuss (if necessary) how they would be addressed in performance optimisation?
I think that addressing these questions would provide a better documentation of this stage of the development of MPTRAC.