An Improved Algorithm for Simulating the Surface Flow Dynamics based on the Flow-Path Network Model
- 1School of Environment and Energy Engineering, Anhui Jianzhu University, Hefei, 230601, China
- 2School of Resource and Environment Science, Wuhan University, Wuhan, 430079, China
- 3Institute of Remote Sensing and Geographic Information Systems, Anhui Jianzhu University, Hefei, 230601, China
- 4School of Architecture and Urban Planning, Anhui Jianzhu University, Hefei, 230601, China
- 5School of Civil Engineering, Anhui Jianzhu University, Hefei, 230601, China
- 1School of Environment and Energy Engineering, Anhui Jianzhu University, Hefei, 230601, China
- 2School of Resource and Environment Science, Wuhan University, Wuhan, 430079, China
- 3Institute of Remote Sensing and Geographic Information Systems, Anhui Jianzhu University, Hefei, 230601, China
- 4School of Architecture and Urban Planning, Anhui Jianzhu University, Hefei, 230601, China
- 5School of Civil Engineering, Anhui Jianzhu University, Hefei, 230601, China
Abstract. This paper proposes an improved algorithm for simulating the surface flow dynamics based on the flow-path network model. This algorithm utilizes the parallel-multi-point method to extract the critical points and the D8 algorithm to retrieve the drainage networks from the regular-grid digital elevation model (DEM) for constructing a drainage-constrained triangulated irregular network (TIN). Then, it combines the flow directions of triangular facets over TIN with resampled flow source points to track flow lines to generate the flow path network (FPN) based on the flow-path network model. On this basis, the proposed algorithm employs three terrain parameters (slope length factor, topographic wetness index and flow path curvature) to improve the classical Manning equation based on the analytic hierarchy process (AHP) to enhance the accuracy of the flow velocity calculation. The topographic wetness index and flow path curvature are derived by the flow-path-network-triangular-facet-network (FPN_TFN) algorithm, a new flow-path-network-topographic-wetness-index (FPN_TWI) algorithm and the flow-path-network-flow-path-curvature (FPN_C) algorithm, respectively. Finally, the velocity estimation function and surface flow discharge simulation function are parallelized by the Compute Unified Device Architecture (CUDA) to enhance its computational efficiency. The outcomes are compared with the algorithm before improvement (TIN_based algorithm) and the SWAT model. The results demonstrate that the speedup ratio reaches 15.7 compared to the TIN_based algorithm. The Nash coefficient increases by 6.49 %, the correlation coefficient decreases slightly, and the balance coefficient increases by 19.08 %. Compared with the SWAT model, the Nash coefficient and correlation coefficient increase by 97.56 % and 4.60 %, respectively. The balance coefficient is close to 1 and outperforms the compared algorithms.
Qianjiao Wu et al.
Status: open (until 22 Jul 2022)
-
CEC1: 'Comment on gmd-2022-92', Juan Antonio Añel, 16 Jun 2022
reply
Dear authors,
After checking your manuscript, it has come to our attention that the "Code and Data Availability" section presents several problems.
First, the section reads: "The code still needs to be improved and will be updates when it's perfect". First, it does not exist such a thing as the perfect code, so such a statement does not make sense. Secondly, the role of such section and repository is not to promote your preferred webpage, the web of a project or link to the newest version of a model but to assure the replicability of your work. To be clear, nobody cares here about an improved and better version of your software but the one you have used for your work and mentioned in the manuscript. Therefore, please, remove this statement and include the DOI of the current Zenodo repository in any reviewed version of your manuscript.
Secondly, the Readme file in the Zenodo repository instructs the user to get code from a GitHub repository. We can not accept this. GitHub is not a suitable repository and instructs authors to use other alternatives for long-term archival and publishing. I guess you refer to the Zenodo repository, so instead of the GitHub repository, use the one of Zenodo.
Third, the Readme file mentions the need to use several proprietary technologies, such as Visual Studio and Cuda 8.0. It is a shame that the replicability of your work is compromised by using non-libre software. Also, you include several binary files .exe, so verifying their code is impossible. This makes me guess that your software could only run on specific (also non-free) operative systems, such as Windows. However, there is no information about OS requirements in your work. You must clarify all these details in the manuscript.
Finally, although the Zenodo repository states that the software license is "Other (Open)" in the files contained, there is no license file that identifies it. If you do not include a license, the code continues to be your property and can not be used by others, despite any statement on being free to use. Therefore, when uploading the model's code to the repository, you could want to choose a free software/open-source (FLOSS) license. We recommend the GPLv3. You only need to include the file 'https://www.gnu.org/licenses/gpl-3.0.txt' as LICENSE.txt with your code. Also, you can choose other options that Zenodo provides: GPLv2, Apache License, MIT License, etc.
Please reply as soon as possible to this comment with the link for it so that it is available for peer-review, as it should be.
Be aware that failing to comply with this request could result in the rejection of your manuscript for publication.Best regards,
Juan A. Añel
Geosci. Model Dev. Exec. Editor-
AC1: 'Reply on CEC1', Qianjiao Wu, 23 Jun 2022
reply
Dear Editor,
Thanks for all of the comments and suggestions for our submission GMD-2022-92. We have carefully examined the comment in the interactive discussion of its preprint, and revised the manuscript accordingly. Detailed correction is listed below point by point.
Specific comments:
First, the section reads: "The code still needs to be improved and will be updates when it's perfect". First, it does not exist such a thing as the perfect code, so such a statement does not make sense. Secondly, the role of such section and repository is not to promote your preferred webpage, the web of a project or link to the newest version of a model but to assure the replicability of your work. To be clear, nobody cares here about an improved and better version of your software but the one you have used for your work and mentioned in the manuscript. Therefore, please, remove this statement and include the DOI of the current Zenodo repository in any reviewed version of your manuscript.
Response: Thanks for the comments. According to the comments, we have removed the statement (“The code still needs to be improved and will be updates when it's perfec”) and included the DOI of the current Zenodo repository. In the revised manuscript, we have changed the section of Code Availability (P25, L480).
Secondly, the Readme file in the Zenodo repository instructs the user to get code from a GitHub repository. We can not accept this. GitHub is not a suitable repository and instructs authors to use other alternatives for long-term archival and publishing. I guess you refer to the Zenodo repository, so instead of the GitHub repository, use the one of Zenodo.
Response: Thanks for the comments. According to the comments, we have revised the Readme file in the Zenodo repository which refers to the Zenodo repository instead of the GitHub repository. In addition, the DOI will be acquired after the code had been archived into the Zenodo repository. So, we have only provided the method to download the code in the Readme file instead of its DOI which have been updated in the revised manuscript.
Third, the Readme file mentions the need to use several proprietary technologies, such as Visual Studio and Cuda 8.0. It is a shame that the replicability of your work is compromised by using non-libre software. Also, you include several binary files .exe, so verifying their code is impossible. This makes me guess that your software could only run on specific (also non-free) operative systems, such as Windows. However, there is no information about OS requirements in your work. You must clarify all these details in the manuscript.
Response: Thanks for the comments. Our software can only run on the Windows operate system which have supplemented in the revises manuscript.
Finally, although the Zenodo repository states that the software license is "Other (Open)" in the files contained, there is no license file that identifies it. If you do not include a license, the code continues to be your property and can not be used by others, despite any statement on being free to use. Therefore, when uploading the model's code to the repository, you could want to choose a free software/open-source (FLOSS) license. We recommend the GPLv3. You only need to include the file 'https://www.gnu.org/licenses/gpl-3.0.txt' as LICENSE.txt with your code. Also, you can choose other options that Zenodo provides: GPLv2, Apache License, MIT License, etc.
Response: Thanks for the comments. We have uploaded a LICENSE.txt with the code into the Zenodo repository according to the GPLv3.
-
AC1: 'Reply on CEC1', Qianjiao Wu, 23 Jun 2022
reply
Qianjiao Wu et al.
Qianjiao Wu et al.
Viewed
HTML | XML | Total | BibTeX | EndNote | |
---|---|---|---|---|---|
215 | 29 | 10 | 254 | 0 | 1 |
- HTML: 215
- PDF: 29
- XML: 10
- Total: 254
- BibTeX: 0
- EndNote: 1
Viewed (geographical distribution)
Country | # | Views | % |
---|
Total: | 0 |
HTML: | 0 |
PDF: | 0 |
XML: | 0 |
- 1